Bug in 2.0.6 "buildconfigs" ?

classic Classic list List threaded Threaded
2 messages Options
tdc
Reply | Threaded
Open this post in threaded view
|

Bug in 2.0.6 "buildconfigs" ?

tdc
I think there is a bug in mk.linux-2.6-* scripts which leads to always
using xenX-defconfigs and ignoring configs in dist/install/boot.

On line 34 in mk.linux-2.6-* you check for file:
$(DESTDIR)/boot/config-$(LINUX_VER)$$CONFIG_VERSION
this evals to filename "config-2.6.11.10$(XENGUEST)", which is obviously
wrong. Makefiles in toplevel kernel trees does have the same error in it
(these are set on line 30 in mk.linux-2.6.*)
Makefile (for xen0) then starts with:
---
VERSION = 2
PATCHLEVEL = 6
SUBLEVEL = 11
EXTRAVERSION = .10$(XENGUEST)
XENGUEST = -xen0
NAME=Woozy Beaver
---

Downloaded today at 13:08 from
http://www.cl.cam.ac.uk/Research/SRG/netos/xen/downloads/xen-2.0.6-src.tgz

Dave


_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel
Reply | Threaded
Open this post in threaded view
|

Re: Bug in 2.0.6 "buildconfigs" ?

Christian Limpach
On 5/23/05, tdc <[hidden email]> wrote:
> I think there is a bug in mk.linux-2.6-* scripts which leads to always
> using xenX-defconfigs and ignoring configs in dist/install/boot.
>
> On line 34 in mk.linux-2.6-* you check for file:
> $(DESTDIR)/boot/config-$(LINUX_VER)$$CONFIG_VERSION
> this evals to filename "config-2.6.11.10$(XENGUEST)", which is obviously
> wrong.

Yeah, I've fixed this now in 2.0-testing and unstable.

> Makefiles in toplevel kernel trees does have the same error in it
> (these are set on line 30 in mk.linux-2.6.*)
> Makefile (for xen0) then starts with:
> ---
> VERSION = 2
> PATCHLEVEL = 6
> SUBLEVEL = 11
> EXTRAVERSION = .10$(XENGUEST)
> XENGUEST = -xen0
> NAME=Woozy Beaver
> ---

That's ok, EXTRAVERSION only gets expanded when it's used -- which is
after XENGUEST is defined.

    christian

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel