[PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

Puthiyaparambil, Aravindh

Signed off by Aravindh Puthiyaparambil
<[hidden email]>

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel

x8664_ksyms.c.diff (908 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

Jan Beulich
I disagree to that. Instead (even in the main kernel, and also on i386)
nmi_callback should completely go away, and the supposedly one user
should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.

Jan

>>> "Puthiyaparambil, Aravindh" <[hidden email]>
09.11.05 21:03:45 >>>

Signed off by Aravindh Puthiyaparambil
<[hidden email]>

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

Andi Kleen
On Thursday 10 November 2005 09:41, Jan Beulich wrote:
> I disagree to that. Instead (even in the main kernel, and also on i386)
> nmi_callback should completely go away, and the supposedly one user
> should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.

I agree with Jan on that.

Haven't see the original patch, but normally it's Linux policy
to not merge EXPORT_SYMBOLs if there are no modular
users of the symbol in tree.

-Andi


_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

Puthiyaparambil, Aravindh
In reply to this post by Puthiyaparambil, Aravindh

> On Thursday 10 November 2005 09:41, Jan Beulich wrote:
> > I disagree to that. Instead (even in the main kernel, and also on
i386)
> > nmi_callback should completely go away, and the supposedly one user
> > should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.

I submitted the patch only because I found that the nmi_callback
functions were being exported in all kernels except the Xen x86_64 one.
I did not realize that they are going away. We are using the functions
in one of our internal modules and I will look into moving away from
using them.


> Haven't see the original patch, but normally it's Linux policy
> to not merge EXPORT_SYMBOLs if there are no modular
> users of the symbol in tree.

I am a little confused here. If that's the case, then why are the
nmi_callback symbols being exported in all kernels but the Xen x86_64
one? I see that it is also being exported in the SLES9 SP2 kernel.

Thanks,
Aravindh

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel