[PATCH] Remove duplicated code in vcpu_pause/domain_pause

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Remove duplicated code in vcpu_pause/domain_pause

Tony Breeds
Hi All,
        Looking at xen/common/domain.c, I saw that domain_pause
duplicates the code from VIP_pause.  This patch eliminates the
duplicate code and makes domain pause a mirror for the existing
domain_unpause.

Is there a reason not to do this?

Signed-off-by: Tony Breeds <[hidden email]>

-----------------

diff -r ccf76e51e7e6 xen/common/domain.c
--- a/xen/common/domain.c Tue Nov 29 16:59:03 2005
+++ b/xen/common/domain.c Wed Nov 30 11:11:56 2005
@@ -293,11 +293,7 @@
     struct vcpu *v;
 
     for_each_vcpu( d, v )
-    {
-        BUG_ON(v == current);
-        atomic_inc(&v->pausecnt);
-        vcpu_sleep_sync(v);
-    }
+ vcpu_pause(v);
 
     sync_pagetable_state(d);
 }



Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2006.linux.org.au/
   Jan 23-28 2006      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel