[PATCH] fix segmentation faults when booting FC3 in vmx domain

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] fix segmentation faults when booting FC3 in vmx domain

Ling, Xiaofeng
# HG changeset patch
# User Xiaofeng Ling <[hidden email]>
# Node ID 722429e8b618adc9f39340ff39fc0d7f4a6b1bec
# Parent  ccf76e51e7e6661df56c35c244fca0a52aa8f481
We need to do sync when mov_to_cr3 to a value already shadowed.
The L2 page and already shadowed L1 page may be out of sync.
This patch fix the problems of segmentation faults and strange prints
when booting Redhat FC3 and make kernel in FC3 in VMX domain.

Signed-off-by: Xiaofeng Ling <[hidden email]>

diff -r ccf76e51e7e6 -r 722429e8b618 xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c Tue Nov 29 17:59:03 2005 +0100
+++ b/xen/arch/x86/shadow.c Wed Nov 30 16:08:41 2005 +0800
@@ -2154,7 +2154,8 @@
  #elif CONFIG_PAGING_LEVELS == 4
          smfn = shadow_l4_table(d, gpfn, gmfn);
  #endif
-    }
+    }else
+        shadow_sync_all(d);
      if ( !get_shadow_ref(smfn) )
          BUG();
      old_smfn = pagetable_get_pfn(v->arch.shadow_table);
diff -r ccf76e51e7e6 -r 722429e8b618 xen/arch/x86/shadow32.c
--- a/xen/arch/x86/shadow32.c Tue Nov 29 17:59:03 2005 +0100
+++ b/xen/arch/x86/shadow32.c Wed Nov 30 16:08:41 2005 +0800
@@ -2911,6 +2911,8 @@
       */
      if ( unlikely(!(smfn = __shadow_status(d, gpfn,
PGT_base_page_table))) )
          smfn = shadow_l2_table(d, gpfn, gmfn);
+    else
+        shadow_sync_all(d);
      if ( !get_shadow_ref(smfn) )
          BUG();
      old_smfn = pagetable_get_pfn(v->arch.shadow_table);

# HG changeset patch
# User Xiaofeng Ling <[hidden email]>
# Node ID 722429e8b618adc9f39340ff39fc0d7f4a6b1bec
# Parent  ccf76e51e7e6661df56c35c244fca0a52aa8f481
We need to do sync when mov_to_cr3 to a value already shadowed.
The L2 page and already shadowed L1 page may out of sync.
This patch fix the problems of segmentation faults and strange prints
when booting Redhat FC3 and make kernel in FC3 in VMX domain.

Signed-off-by: Xiaofeng Ling <[hidden email]>

diff -r ccf76e51e7e6 -r 722429e8b618 xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c Tue Nov 29 17:59:03 2005 +0100
+++ b/xen/arch/x86/shadow.c Wed Nov 30 16:08:41 2005 +0800
@@ -2154,7 +2154,8 @@
 #elif CONFIG_PAGING_LEVELS == 4
         smfn = shadow_l4_table(d, gpfn, gmfn);
 #endif
-    }
+    }else
+        shadow_sync_all(d);
     if ( !get_shadow_ref(smfn) )
         BUG();
     old_smfn = pagetable_get_pfn(v->arch.shadow_table);
diff -r ccf76e51e7e6 -r 722429e8b618 xen/arch/x86/shadow32.c
--- a/xen/arch/x86/shadow32.c Tue Nov 29 17:59:03 2005 +0100
+++ b/xen/arch/x86/shadow32.c Wed Nov 30 16:08:41 2005 +0800
@@ -2911,6 +2911,8 @@
      */
     if ( unlikely(!(smfn = __shadow_status(d, gpfn, PGT_base_page_table))) )
         smfn = shadow_l2_table(d, gpfn, gmfn);
+    else
+        shadow_sync_all(d);
     if ( !get_shadow_ref(smfn) )
         BUG();
     old_smfn = pagetable_get_pfn(v->arch.shadow_table);

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel