[PATCH] remove use of get_gendisk in blkfront

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] remove use of get_gendisk in blkfront

Ling, Xiaofeng
remove use of get_gendisk in blkfront
gen_gendisk is no long exported by 2.6 kernel. this patch remove the
call of get_gendisk by saving the gd point in blkfront_info in vbd.c so
that blkfront can be built as kerenl module.

Signed-off-by: Xiaofeng Ling <[hidden email]>


diff -r 864434653dab linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c
--- a/linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c
+++ b/linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c
@@ -660,6 +651,7 @@
  info->vdevice = vdevice;
  info->connected = BLKIF_STATE_DISCONNECTED;
  info->mi = NULL;
+ info->gd = NULL;
  INIT_WORK(&info->work, blkif_restart_queue, (void *)info);
 
  info->shadow_free = 0;
diff -r 864434653dab linux-2.6-xen-sparse/drivers/xen/blkfront/block.h
--- a/linux-2.6-xen-sparse/drivers/xen/blkfront/block.h
+++ b/linux-2.6-xen-sparse/drivers/xen/blkfront/block.h
@@ -115,6 +115,7 @@
  /* We watch the backend */
  struct xenbus_watch watch;
  dev_t dev;
+ struct gendisk *gd;
  int vdevice;
  blkif_vdev_t handle;
  int connected;
diff -r 864434653dab linux-2.6-xen-sparse/drivers/xen/blkfront/vbd.c
--- a/linux-2.6-xen-sparse/drivers/xen/blkfront/vbd.c
+++ b/linux-2.6-xen-sparse/drivers/xen/blkfront/vbd.c
@@ -266,6 +257,7 @@
  gd->flags |= GENHD_FL_CD;
 
  add_disk(gd);
+ info->gd = gd;
 
  return 0;
 
@@ -298,23 +290,19 @@
 void
 xlvbd_del(struct blkfront_info *info)
 {
- struct block_device *bd;
  struct gendisk *gd;
  int unused;
  request_queue_t *rq;
 
- bd = bdget(info->dev);
- if (bd == NULL)
+ gd = info->gd;
+ if (gd == NULL)
  return;
 
- gd = get_gendisk(info->dev, &unused);
  rq = gd->queue;
-
  del_gendisk(gd);
  put_disk(gd);
  xlbd_put_major_info(info->mi);
  info->mi = NULL;
  blk_cleanup_queue(rq);
 
- bdput(bd);
-}
+}

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] remove use of get_gendisk in blkfront

Jeremy Katz
On Fri, 2005-09-02 at 16:28 +0800, Xiaofeng Ling wrote:
> remove use of get_gendisk in blkfront
> gen_gendisk is no long exported by 2.6 kernel. this patch remove the
> call of get_gendisk by saving the gd point in blkfront_info in vbd.c so
> that blkfront can be built as kerenl module.
>
> Signed-off-by: Xiaofeng Ling <[hidden email]>

This looks correct to me and helps in building blkfront as a module.
Any chance of getting it committed?  I've gone ahead and rediffed
against the current tip and cleaned up the warnings.  Attached here.

Signed-off-by: Jeremy Katz <[hidden email]>

Jeremy

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel

xen-get-gendisk.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] remove use of get_gendisk in blkfront

Ian Pratt
In reply to this post by Ling, Xiaofeng
> On Fri, 2005-09-02 at 16:28 +0800, Xiaofeng Ling wrote:
> > remove use of get_gendisk in blkfront
> > gen_gendisk is no long exported by 2.6 kernel. this patch
> remove the
> > call of get_gendisk by saving the gd point in blkfront_info
> in vbd.c
> > so that blkfront can be built as kerenl module.
> >
> > Signed-off-by: Xiaofeng Ling <[hidden email]>
>
> This looks correct to me and helps in building blkfront as a module.
> Any chance of getting it committed?  I've gone ahead and
> rediffed against the current tip and cleaned up the warnings.
>  Attached here.

Looks good to me -- AFAIK it was only dropped by accident first time
around.

Folks: if you submit a patch for inclusion please keep resending every
48h until you get some kind of response or it's committed.

[Aside: it would be really nice if there was some tool that pulled
patches off a mailing list and fed them into something like bugzilla,
along with all the coments associated with a patch. It should also watch
the changelog list and update the status as 'APPLIED' when appropriate.
At any time an author could withdraw/supercede a patch, and a maintainer
could reject/keep-on-file. A really smart system would also keep patches
fresh by trying to rebase them, or at least note if they still apply
cleanly.]

Thanks,
Ian


_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] remove use of get_gendisk in blkfront

Josh Boyer-3
On 11/9/05, Ian Pratt <[hidden email]> wrote:
>
> [Aside: it would be really nice if there was some tool that pulled
> patches off a mailing list and fed them into something like bugzilla,
> along with all the coments associated with a patch. It should also watch
> the changelog list and update the status as 'APPLIED' when appropriate.
> At any time an author could withdraw/supercede a patch, and a maintainer
> could reject/keep-on-file. A really smart system would also keep patches
> fresh by trying to rebase them, or at least note if they still apply
> cleanly.]

Jeremy Kerr wrote a tool called patchwork that sort of does that.
It's not nearly as full featured as you'd like, but the basic idea is
there.

The project page is at:
http://www.ozlabs.org/~jk/projects/patchwork/

And an example of it running is at:
http://patchwork.ozlabs.org/linuxppc64/

josh

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] remove use of get_gendisk in blkfront

Ling, Xiaofeng
In reply to this post by Ling, Xiaofeng
Ian, this is one of the patches to enable para-driver in unmodified linux.
how about the other patches now?
Any comments for them?

Ian Pratt <> wrote:

>> On Fri, 2005-09-02 at 16:28 +0800, Xiaofeng Ling wrote:
>>> remove use of get_gendisk in blkfront gen_gendisk is no long
>>> exported by 2.6 kernel. this patch
>> remove the
>>> call of get_gendisk by saving the gd point in blkfront_info in vbd.c
>>> so that blkfront can be built as kerenl module.
>>>
>>> Signed-off-by: Xiaofeng Ling <[hidden email]>
>>
>> This looks correct to me and helps in building blkfront as a module.
>> Any chance of getting it committed?  I've gone ahead and rediffed
>> against the current tip and cleaned up the warnings.
>>  Attached here.
>
> Looks good to me -- AFAIK it was only dropped by accident first time
> around.
>
> Folks: if you submit a patch for inclusion please keep resending
> every 48h until you get some kind of response or it's committed.
>
> [Aside: it would be really nice if there was some tool that pulled
> patches off a mailing list and fed them into something like bugzilla,
> along with all the coments associated with a patch. It should also
> watch the changelog list and update the status as 'APPLIED' when
> appropriate. At any time an author could withdraw/supercede a patch,
> and a maintainer could reject/keep-on-file. A really smart system
> would also keep patches fresh by trying to rebase them, or at least
> note if they still apply cleanly.]      
>
> Thanks,
> Ian
>
>
> _______________________________________________
> Xen-devel mailing list
> [hidden email]
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
[hidden email]
http://lists.xensource.com/xen-devel