[PATCH] trivial xen SMP build fix

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] trivial xen SMP build fix

Alex Williamson

   Patch below allows xen to build with CONFIG_XEN_SMP.  There's a
redefinition of sprintf in efi.h with the original ordering.  It seems
to boot with this change, but I won't claim it entirely works.  Thanks,

        Alex

--
Signed-off-by: Alex Williamson <[hidden email]>

diff -r be53bbe62f2e xen/arch/ia64/linux-xen/sal.c
--- a/xen/arch/ia64/linux-xen/sal.c Wed Nov  9 21:31:01 2005
+++ b/xen/arch/ia64/linux-xen/sal.c Wed Nov  9 15:46:21 2005
@@ -14,12 +14,12 @@
 #include <linux/spinlock.h>
 #include <linux/string.h>
 
+#ifdef XEN
+#include <linux/smp.h>
+#endif
 #include <asm/page.h>
 #include <asm/sal.h>
 #include <asm/pal.h>
-#ifdef XEN
-#include <linux/smp.h>
-#endif
 
  __cacheline_aligned DEFINE_SPINLOCK(sal_lock);
 unsigned long sal_platform_features;



_______________________________________________
Xen-ia64-devel mailing list
[hidden email]
http://lists.xensource.com/xen-ia64-devel
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] trivial xen SMP build fix

Dan Magenheimer
Are you using gcc 3.4 (or newer)?

> -----Original Message-----
> From: Williamson, Alex (Linux Kernel Dev)
> Sent: Wednesday, November 09, 2005 3:59 PM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: [hidden email]
> Subject: [PATCH] trivial xen SMP build fix
>
>
>    Patch below allows xen to build with CONFIG_XEN_SMP.  There's a
> redefinition of sprintf in efi.h with the original ordering.  It seems
> to boot with this change, but I won't claim it entirely
> works.  Thanks,
>
> Alex
>
> --
> Signed-off-by: Alex Williamson <[hidden email]>
>
> diff -r be53bbe62f2e xen/arch/ia64/linux-xen/sal.c
> --- a/xen/arch/ia64/linux-xen/sal.c Wed Nov  9 21:31:01 2005
> +++ b/xen/arch/ia64/linux-xen/sal.c Wed Nov  9 15:46:21 2005
> @@ -14,12 +14,12 @@
>  #include <linux/spinlock.h>
>  #include <linux/string.h>
>  
> +#ifdef XEN
> +#include <linux/smp.h>
> +#endif
>  #include <asm/page.h>
>  #include <asm/sal.h>
>  #include <asm/pal.h>
> -#ifdef XEN
> -#include <linux/smp.h>
> -#endif
>  
>   __cacheline_aligned DEFINE_SPINLOCK(sal_lock);
>  unsigned long sal_platform_features;
>
>
>

_______________________________________________
Xen-ia64-devel mailing list
[hidden email]
http://lists.xensource.com/xen-ia64-devel
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] trivial xen SMP build fix

Alex Williamson
On Wed, 2005-11-09 at 15:07 -0800, Magenheimer, Dan (HP Labs Fort
Collins) wrote:
> Are you using gcc 3.4 (or newer)?

   Yep:

Reading specs from /usr/lib/gcc/ia64-linux-gnu/3.4.5/specs
Configured with: ../src/configure -v --enable-languages=c,c
++,f77,pascal,objc,ada --prefix=/usr --libexecdir=/usr/lib
--with-gxx-include-dir=/usr/include/c++/3.4 --enable-shared
--with-system-zlib --enable-nls --without-included-gettext
--program-suffix=-3.4 --enable-__cxa_atexit
--enable-libstdcxx-allocator=mt --enable-clocale=gnu
--enable-libstdcxx-debug --with-system-libunwind ia64-linux-gnu
Thread model: posix
gcc version 3.4.5 20050821 (prerelease) (Debian 3.4.4-8)

--
Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-ia64-devel mailing list
[hidden email]
http://lists.xensource.com/xen-ia64-devel