[Patch] Remove created symlinks on clean

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] Remove created symlinks on clean

Simon Horman
Remove created symlinks on clean

I noticed some weirdness when copying trees around because
these links weren't removed on a clean. This fix seems
correct to me, and at worst harmless.

Signed-Off-By: Horms <[hidden email]>

diff -r 0e4958eff781 -r 8c7770e5d673 xen/arch/ia64/Makefile
--- a/xen/arch/ia64/Makefile Fri Jan 13 02:55:50 2006
+++ b/xen/arch/ia64/Makefile Fri Jan 13 04:31:22 2006
@@ -137,5 +137,10 @@
  rm -f *.o *~ core  xen.lds.s $(BASEDIR)/include/asm-ia64/.offsets.h.stamp asm-offsets.s map.out
  rm -f asm-xsi-offsets.s $(BASEDIR)/include/asm-ia64/asm-xsi-offsets.h
  rm -f linux/lib/*.o
+ rm -f $(BASEDIR)/include/linux $(BASEDIR)/include/asm-ia64/xen \
+ $(BASEDIR)/include/asm-ia64/vmx_vpic.h \
+ $(BASEDIR)/include/asm-ia64/vmx_vioapic.h \
+ $(BASEDIR)/arch/ia64/vmx/vmx_vioapic.c \
+ $(BASEDIR)/arch/ia64/vmx/vmx_vioapic
 
 .PHONY: default clean


_______________________________________________
Xen-ia64-devel mailing list
[hidden email]
http://lists.xensource.com/xen-ia64-devel
Reply | Threaded
Open this post in threaded view
|

RE: [Patch] Remove created symlinks on clean

Dan Magenheimer
Agree that this is needed but since this is patching a hack...

Could someone with knowledge and ability to test VTI and VTx
and Xen/ia64 and Xen/x86 submit a patch to xen-devel to move
these files to a common location (e.g. xen/common/vmx/vmx_ioapic.c
and xen/include/xen/vmx/vmx_vpic.h etc.), change all the
necessary #include lines in various files, and remove the
creation of the symbolic links from the ia64 Makefile?

I don't know if any of these files are affected by the HVM
work, but it might be good to get Leendert's input also
to anticipate and avoid possible objections from Keir.

Thanks,
Dan

> -----Original Message-----
> From: [hidden email]
> [mailto:[hidden email]] On Behalf Of Horms
> Sent: Thursday, January 12, 2006 9:34 PM
> To: [hidden email]
> Subject: [Xen-ia64-devel] [Patch] Remove created symlinks on clean
>
> Remove created symlinks on clean
>
> I noticed some weirdness when copying trees around because
> these links weren't removed on a clean. This fix seems
> correct to me, and at worst harmless.
>
> Signed-Off-By: Horms <[hidden email]>
>
> diff -r 0e4958eff781 -r 8c7770e5d673 xen/arch/ia64/Makefile
> --- a/xen/arch/ia64/Makefile Fri Jan 13 02:55:50 2006
> +++ b/xen/arch/ia64/Makefile Fri Jan 13 04:31:22 2006
> @@ -137,5 +137,10 @@
>   rm -f *.o *~ core  xen.lds.s
> $(BASEDIR)/include/asm-ia64/.offsets.h.stamp asm-offsets.s map.out
>   rm -f asm-xsi-offsets.s
> $(BASEDIR)/include/asm-ia64/asm-xsi-offsets.h
>   rm -f linux/lib/*.o
> + rm -f $(BASEDIR)/include/linux $(BASEDIR)/include/asm-ia64/xen \
> + $(BASEDIR)/include/asm-ia64/vmx_vpic.h \
> + $(BASEDIR)/include/asm-ia64/vmx_vioapic.h \
> + $(BASEDIR)/arch/ia64/vmx/vmx_vioapic.c \
> + $(BASEDIR)/arch/ia64/vmx/vmx_vioapic
>  
>  .PHONY: default clean
>
>
> _______________________________________________
> Xen-ia64-devel mailing list
> [hidden email]
> http://lists.xensource.com/xen-ia64-devel
>

_______________________________________________
Xen-ia64-devel mailing list
[hidden email]
http://lists.xensource.com/xen-ia64-devel