RE: [PATCH] fixed asm-offset.h asm-xsi-offset.hgeneration

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] fixed asm-offset.h asm-xsi-offset.hgeneration

Dan Magenheimer
Committed.

> -----Original Message-----
> From: Isaku Yamahata [mailto:[hidden email]]
> Sent: Thursday, December 15, 2005 7:59 PM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: [hidden email]
> Subject: Re: [Xen-ia64-devel] [PATCH] fixed asm-offset.h
> asm-xsi-offset.hgeneration
>
>
>
> Hi.
>
> On Thu, Dec 15, 2005 at 11:57:33AM -0800, Magenheimer, Dan
> (HP Labs Fort Collins) wrote:
> > The sed line that is used is exactly the same as in linux
> > (see sed-y in linux-2.6.14/Kbuild) so I don't think that
> > the Xen team will change the Makefile.  Does vanilla
> > binutils work to build Linux?
>
> Yes. It is because Linux doesn't define negative value
> in asm-offsets.h.
>
> I agree that the Xen team won't accept.
> This probelem is ia64-specific so that it sould be solved
> ia64-specifically.
> (SHARED_ARCHINFO_ADDR is defined as a large negative value.)
> How about this patch?
>
>
> Signed-off-by: Isaku Yamahata <[hidden email]>
>
> --
>
> diff -r 7ef565a7cc86 xen/arch/ia64/asm-offsets.c
> --- a/xen/arch/ia64/asm-offsets.c Thu Dec 15 17:17:06 2005 -0600
> +++ b/xen/arch/ia64/asm-offsets.c Fri Dec 16 11:43:20 2005 +0900
> @@ -15,7 +15,7 @@
>  #define task_struct vcpu
>  
>  #define DEFINE(sym, val) \
> -        asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> +        asm volatile("\n->" #sym " (%0) " #val : : "i" (val))
>  
>  #define BLANK() asm volatile("\n->" : : )
>  
> diff -r 7ef565a7cc86 xen/arch/ia64/asm-xsi-offsets.c
> --- a/xen/arch/ia64/asm-xsi-offsets.c Thu Dec 15 17:17:06 2005 -0600
> +++ b/xen/arch/ia64/asm-xsi-offsets.c Fri Dec 16 11:43:20 2005 +0900
> @@ -38,7 +38,7 @@
>  #define task_struct vcpu
>  
>  #define DEFINE(sym, val) \
> -        asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> +        asm volatile("\n->" #sym " (%0) " #val : : "i" (val))
>  
>  #define BLANK() asm volatile("\n->" : : )
>  
>
> --
> yamahata
>

_______________________________________________
Xen-ia64-devel mailing list
[hidden email]
http://lists.xensource.com/xen-ia64-devel