[qemu-xen master] spapr: add missing break in h_get_cpu_characteristics()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[qemu-xen master] spapr: add missing break in h_get_cpu_characteristics()

patchbot
commit 00e9fba2beb4a0366965ce4ec1068df68ce9f4c0
Author:     Greg Kurz <[hidden email]>
AuthorDate: Thu Feb 1 20:47:41 2018 +0100
Commit:     Michael Roth <[hidden email]>
CommitDate: Mon Feb 12 19:39:27 2018 -0600

    spapr: add missing break in h_get_cpu_characteristics()
   
    Detected by Coverity (CID 1385702). This fixes the recently added hypercall
    to let guests properly apply Spectre and Meltdown workarounds.
   
    Fixes: c59704b25473 "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS"
    Reported-by: Paolo Bonzini <[hidden email]>
    Signed-off-by: Greg Kurz <[hidden email]>
    Reviewed-by: Suraj Jitindar Singh <[hidden email]>
    Signed-off-by: David Gibson <[hidden email]>
    (cherry picked from commit fa86f59234919b479b7e8da6b0dc2dad894a5eac)
    Signed-off-by: Michael Roth <[hidden email]>
---
 hw/ppc/spapr_hcall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 0e1a0ae..8416452 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -1698,6 +1698,7 @@ static target_ulong h_get_cpu_characteristics(PowerPCCPU *cpu,
     switch (safe_indirect_branch) {
     case SPAPR_CAP_FIXED:
         characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED;
+        break;
     default: /* broken */
         assert(safe_indirect_branch == SPAPR_CAP_BROKEN);
         break;
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog