[qemu-xen master] target/sh4: fix TCG leak during gusa sequence

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[qemu-xen master] target/sh4: fix TCG leak during gusa sequence

patchbot
commit ea311a995999f82f1647f4fd4967d4e8b3fbd806
Author:     Alex Bennée <[hidden email]>
AuthorDate: Wed Dec 6 09:30:50 2017 +0000
Commit:     Michael Roth <[hidden email]>
CommitDate: Mon Jan 8 07:52:41 2018 -0600

    target/sh4: fix TCG leak during gusa sequence
   
    This fixes bug #1735384 while running java under qemu-sh4. When debug
    was enabled it showed a problem with TCG temps. Once fixed I was able
    to run java -version normally.
   
    Cc: [hidden email]
    Reported-by: John Paul Adrian Glaubitz <[hidden email]>
    Suggested-by: Richard Henderson <[hidden email]>
    Signed-off-by: Alex Bennée <[hidden email]>
    Message-Id: <[hidden email]>
    Reviewed-by: Richard Henderson <[hidden email]>
    Reviewed-by: Aurelien Jarno <[hidden email]>
    Signed-off-by: Aurelien Jarno <[hidden email]>
    (cherry picked from commit 6d56fc6cc372284a4571f09b361a9ccd99318103)
    Signed-off-by: Michael Roth <[hidden email]>
---
 target/sh4/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 703020f..b4b5c82 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -2189,7 +2189,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State *env, int *pmax_insns)
     }
 
     /* If op_src is not a valid register, then op_arg was a constant.  */
-    if (op_src < 0) {
+    if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) {
         tcg_temp_free_i32(op_arg);
     }
 
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master


_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog