[qemu-xen master] ui: avoid pointless VNC updates if framebuffer isn't dirty

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[qemu-xen master] ui: avoid pointless VNC updates if framebuffer isn't dirty

patchbot
commit 616d64ac06c1bc8ad4954827b0655c59169e8585
Author:     Daniel P. Berrange <[hidden email]>
AuthorDate: Mon Dec 18 19:12:19 2017 +0000
Commit:     Michael Roth <[hidden email]>
CommitDate: Mon Feb 12 18:33:39 2018 -0600

    ui: avoid pointless VNC updates if framebuffer isn't dirty
   
    The vnc_update_client() method checks the 'has_dirty' flag to see if there are
    dirty regions that are pending to send to the client. Regardless of this flag,
    if a forced update is requested, updates must be sent. For unknown reasons
    though, the code also tries to sent updates if audio capture is enabled. This
    makes no sense as audio capture state does not impact framebuffer contents, so
    this check is removed.
   
    Signed-off-by: Daniel P. Berrange <[hidden email]>
    Reviewed-by: Darren Kenny <[hidden email]>
    Reviewed-by: Marc-André Lureau <[hidden email]>
    Message-id: [hidden email]
    Signed-off-by: Gerd Hoffmann <[hidden email]>
    (cherry picked from commit 3541b08475d51bddf8aded36576a0ff5a547a978)
    Signed-off-by: Michael Roth <[hidden email]>
---
 ui/vnc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index a61fcbd..f53eddb 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -984,7 +984,7 @@ static int vnc_update_client(VncState *vs, int has_dirty)
         return 0;
     }
 
-    if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) {
+    if (!vs->has_dirty && !vs->force_update) {
         return 0;
     }
 
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master


_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog