[qemu-xen master] virtio_error: don't invoke status callbacks

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[qemu-xen master] virtio_error: don't invoke status callbacks

commit f79312153902cb486c67a9817c4d827f67cd41ff
Author:     Michael S. Tsirkin <[hidden email]>
AuthorDate: Wed Dec 13 21:59:54 2017 +0200
Commit:     Michael Roth <[hidden email]>
CommitDate: Mon Jan 15 18:18:05 2018 -0600

    virtio_error: don't invoke status callbacks
    Backends don't need to know what frontend requested a reset,
    and notifying then from virtio_error is messy because
    virtio_error itself might be invoked from backend.
    Let's just set the status directly.
    Cc: [hidden email]
    Reported-by: Ilya Maximets <[hidden email]>
    Signed-off-by: Michael S. Tsirkin <[hidden email]>
    (cherry picked from commit 8fc47c876de638353bb635872f2c25bb7f4a3d6e)
    Signed-off-by: Michael Roth <[hidden email]>
 hw/virtio/virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index ad564b0..d6002ee 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2469,7 +2469,7 @@ void GCC_FMT_ATTR(2, 3) virtio_error(VirtIODevice *vdev, const char *fmt, ...)
     if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {
-        virtio_set_status(vdev, vdev->status | VIRTIO_CONFIG_S_NEEDS_RESET);
+        vdev->status = vdev->status | VIRTIO_CONFIG_S_NEEDS_RESET;
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

Xen-changelog mailing list
[hidden email]