[xen master] arm/xen: vpl011: Fix the slow early console SBSA UART output

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] arm/xen: vpl011: Fix the slow early console SBSA UART output

patchbot
commit 393a541f7d151242f186ad2fb9b6c20db1db6cb9
Author:     Bhupinder Thakur <[hidden email]>
AuthorDate: Tue Oct 24 18:09:21 2017 +0100
Commit:     Stefano Stabellini <[hidden email]>
CommitDate: Fri Oct 27 10:11:05 2017 -0700

    arm/xen: vpl011: Fix the slow early console SBSA UART output
   
    The early console output uses pl011_early_write() to write data. This
    function waits for BUSY bit to get cleared before writing the next byte.
   
    In the SBSA UART emulation logic, the BUSY bit was set as soon one
    byte was written in the FIFO and it remained set until the FIFO was
    emptied. This meant that the output was delayed as each character needed
    the BUSY to get cleared.
   
    Since the SBSA UART is getting emulated in Xen using ring buffers, it
    ensures that once the data is enqueued in the FIFO, it will be received
    by xenconsole so it is safe to set the BUSY bit only when FIFO becomes
    full. This will ensure that pl011_early_write() is not delayed unduly
    to write the data.
   
    Signed-off-by: Bhupinder Thakur <[hidden email]>
    Reviewed-by: Andre Przywara <[hidden email]>
    Signed-off-by: Andre Przywara <[hidden email]>
    Reviewed-by: Stefano Stabellini <[hidden email]>
    Release-acked-by: Julien Grall <[hidden email]>
---
 xen/arch/arm/vpl011.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
index f7ddccb..0b07436 100644
--- a/xen/arch/arm/vpl011.c
+++ b/xen/arch/arm/vpl011.c
@@ -159,9 +159,15 @@ static void vpl011_write_data(struct domain *d, uint8_t data)
     {
         vpl011->uartfr |= TXFF;
         vpl011->uartris &= ~TXI;
-    }
 
-    vpl011->uartfr |= BUSY;
+        /*
+         * This bit is set only when FIFO becomes full. This ensures that
+         * the SBSA UART driver can write the early console data as fast as
+         * possible, without waiting for the BUSY bit to get cleared before
+         * writing each byte.
+         */
+        vpl011->uartfr |= BUSY;
+    }
 
     vpl011->uartfr &= ~TXFE;
 
@@ -371,11 +377,16 @@ static void vpl011_data_avail(struct domain *d)
     {
         vpl011->uartfr &= ~TXFF;
         vpl011->uartris |= TXI;
+
+        /*
+         * Clear the BUSY bit as soon as space becomes available
+         * so that the SBSA UART driver can start writing more data
+         * without any further delay.
+         */
+        vpl011->uartfr &= ~BUSY;
+
         if ( out_ring_qsize == 0 )
-        {
-            vpl011->uartfr &= ~BUSY;
             vpl011->uartfr |= TXFE;
-        }
     }
 
     vpl011_update_interrupt_status(d);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog