[xen master] gnttab: correct GNTTABOP_cache_flush empty batch handling

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] gnttab: correct GNTTABOP_cache_flush empty batch handling

patchbot
commit 9c22e4d67f5552c7c896ed83bd95d5d4c5837a9d
Author:     Jan Beulich <[hidden email]>
AuthorDate: Mon Dec 4 11:03:32 2017 +0100
Commit:     Jan Beulich <[hidden email]>
CommitDate: Mon Dec 4 11:03:32 2017 +0100

    gnttab: correct GNTTABOP_cache_flush empty batch handling
   
    Jann validly points out that with a caller bogusly requesting a zero-
    element batch with non-zero high command bits (the ones used for
    continuation encoding), the assertion right before the call to
    hypercall_create_continuation() would trigger. A similar situation would
    arise afaict for non-empty batches with op and/or length zero in every
    element.
   
    While we want the former to succeed (as we do elsewhere for similar
    no-op requests), the latter can clearly be converted to an error, as
    this is a state that can't be the result of a prior operation.
   
    Take the opportunity and also correct the order of argument checks:
    We shouldn't accept zero-length elements with unknown bits set in "op".
    Also constify cache_flush()'s first parameter.
   
    Reported-by: Jann Horn <[hidden email]>
    Signed-off-by: Jan Beulich <[hidden email]>
    Reviewed-by: Andre Przywara <[hidden email]>
    Acked-by: Stefano Stabellini <[hidden email]>
---
 xen/common/grant_table.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index c5950f2..bce224b 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -3208,7 +3208,7 @@ gnttab_swap_grant_ref(XEN_GUEST_HANDLE_PARAM(gnttab_swap_grant_ref_t) uop,
     return 0;
 }
 
-static int cache_flush(gnttab_cache_flush_t *cflush, grant_ref_t *cur_ref)
+static int cache_flush(const gnttab_cache_flush_t *cflush, grant_ref_t *cur_ref)
 {
     struct domain *d, *owner;
     struct page_info *page;
@@ -3218,19 +3218,17 @@ static int cache_flush(gnttab_cache_flush_t *cflush, grant_ref_t *cur_ref)
 
     if ( (cflush->offset >= PAGE_SIZE) ||
          (cflush->length > PAGE_SIZE) ||
-         (cflush->offset + cflush->length > PAGE_SIZE) )
+         (cflush->offset + cflush->length > PAGE_SIZE) ||
+         (cflush->op & ~(GNTTAB_CACHE_INVAL | GNTTAB_CACHE_CLEAN)) )
         return -EINVAL;
 
     if ( cflush->length == 0 || cflush->op == 0 )
-        return 0;
+        return !*cur_ref ? 0 : -EILSEQ;
 
     /* currently unimplemented */
     if ( cflush->op & GNTTAB_CACHE_SOURCE_GREF )
         return -EOPNOTSUPP;
 
-    if ( cflush->op & ~(GNTTAB_CACHE_INVAL|GNTTAB_CACHE_CLEAN) )
-        return -EINVAL;
-
     d = rcu_lock_current_domain();
     mfn = cflush->a.dev_bus_addr >> PAGE_SHIFT;
 
@@ -3310,6 +3308,9 @@ gnttab_cache_flush(XEN_GUEST_HANDLE_PARAM(gnttab_cache_flush_t) uop,
         *cur_ref = 0;
         guest_handle_add_offset(uop, 1);
     }
+
+    *cur_ref = 0;
+
     return 0;
 }
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog