[xen master] libxc: bail immediately when PV superpage is discovered

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[xen master] libxc: bail immediately when PV superpage is discovered

patchbot
commit a63334ef13e4a43f1265c9117216cd5ae1bdc659
Author:     Wei Liu <[hidden email]>
AuthorDate: Wed Jul 26 08:44:56 2017 +0100
Commit:     Wei Liu <[hidden email]>
CommitDate: Thu Jul 27 11:26:00 2017 +0100

    libxc: bail immediately when PV superpage is discovered
   
    The original code was added with the hope that PV superpage migration
    might work. But it was never proven that the code actually worked.
   
    Now that PV superpage is gone, simplify the code by returning error
    immediately.
   
    Suggested-by: Andrew Cooper <[hidden email]>
    Signed-off-by: Wei Liu <[hidden email]>
    Reviewed-by: Andrew Cooper <[hidden email]>
    Acked-by: Konrad Rzeszutek Wilk <[hidden email]>
---
 tools/libxc/xc_sr_save_x86_pv.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/tools/libxc/xc_sr_save_x86_pv.c b/tools/libxc/xc_sr_save_x86_pv.c
index 36b1058..ff5efe9 100644
--- a/tools/libxc/xc_sr_save_x86_pv.c
+++ b/tools/libxc/xc_sr_save_x86_pv.c
@@ -975,14 +975,9 @@ static int normalise_pagetable(struct xc_sr_context *ctx, const uint64_t *src,
 
             if ( (type > XEN_DOMCTL_PFINFO_L1TAB) && (pte & _PAGE_PSE) )
             {
-                if ( !ctx->dominfo.paused )
-                    errno = EAGAIN;
-                else
-                {
-                    ERROR("Cannot migrate superpage (L%lu[%u]: 0x%016"PRIx64")",
-                          type >> XEN_DOMCTL_PFINFO_LTAB_SHIFT, i, pte);
-                    errno = E2BIG;
-                }
+                ERROR("Cannot migrate superpage (L%lu[%u]: 0x%016"PRIx64")",
+                      type >> XEN_DOMCTL_PFINFO_LTAB_SHIFT, i, pte);
+                errno = E2BIG;
                 return -1;
             }
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog
Loading...