[xen master] x86/msr: Correct the definition of MSR_IA32_APICBASE_BASE

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] x86/msr: Correct the definition of MSR_IA32_APICBASE_BASE

patchbot
commit dbc4b6e13a5d0dd8967cde7ff7000ab1ed88625e
Author:     Andrew Cooper <[hidden email]>
AuthorDate: Fri Aug 5 14:51:13 2016 +0100
Commit:     Andrew Cooper <[hidden email]>
CommitDate: Tue Oct 3 17:45:24 2017 +0100

    x86/msr: Correct the definition of MSR_IA32_APICBASE_BASE
   
    0xfffff << 12 is undefined behaviour, due to shifting into the sign bit of an
    integer.
   
    Spotted by the Undefined Behaviour Sanitiser
   
    Signed-off-by: Andrew Cooper <[hidden email]>
    Reviewed-by: Wei Liu <[hidden email]>
---
 xen/include/asm-x86/msr-index.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-x86/msr-index.h b/xen/include/asm-x86/msr-index.h
index 4e08de6..b99c623 100644
--- a/xen/include/asm-x86/msr-index.h
+++ b/xen/include/asm-x86/msr-index.h
@@ -305,7 +305,7 @@
 #define MSR_IA32_APICBASE_BSP (1<<8)
 #define MSR_IA32_APICBASE_EXTD (1<<10)
 #define MSR_IA32_APICBASE_ENABLE (1<<11)
-#define MSR_IA32_APICBASE_BASE (0xfffff<<12)
+#define MSR_IA32_APICBASE_BASE 0x000ffffffffff000ul
 #define MSR_IA32_APICBASE_MSR           0x800
 #define MSR_IA32_APICTPR_MSR            0x808
 #define MSR_IA32_APICPPR_MSR            0x80a
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog