[xen master] x86/public: Further corrections to vcpu context comments

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] x86/public: Further corrections to vcpu context comments

patchbot
commit 63aeb7f0da8930d4eac71db6b634db0b052f8555
Author:     Andrew Cooper <[hidden email]>
AuthorDate: Fri Sep 1 14:14:17 2017 +0100
Commit:     Andrew Cooper <[hidden email]>
CommitDate: Fri Sep 1 18:33:06 2017 +0100

    x86/public: Further corrections to vcpu context comments
   
    VCPUOP_initialise and DOMCTL_setvcpucontext are not symetric.
   
    Signed-off-by: Andrew Cooper <[hidden email]>
    Acked-by: Jan Beulich <[hidden email]>
    Reviewed-by: Roger Pau Monné <[hidden email]>
---
 xen/include/public/arch-x86/xen.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 3f68a43..ff91831 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -162,10 +162,12 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */
  * The following is all CPU context. Note that the fpu_ctxt block is filled
  * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used.
  *
- * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise for
- * HVM guests, not all information in this structure is updated, the fields
- * read include: fpu_ctxt (if VGCT_I387_VALID is set), flags, user_regs and
- * debugreg[*].
+ * Also note that when calling DOMCTL_setvcpucontext for HVM guests, not all
+ * information in this structure is updated, the fields read include: fpu_ctxt
+ * (if VGCT_I387_VALID is set), flags, user_regs and debugreg[*].
+ *
+ * Note: VCPUOP_initialise for HVM guests is non-symetric with
+ * DOMCTL_setvcpucontext, and uses struct vcpu_hvm_context from hvm/hvm_vcpu.h
  */
 struct vcpu_guest_context {
     /* FPU registers come first so they can be aligned for FXSAVE/FXRSTOR. */
--
generated by git-patchbot for /home/xen/git/xen.git#master


_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog