[xen master] x86/pv: Fix bugs with the handling of int80_bounce

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] x86/pv: Fix bugs with the handling of int80_bounce

patchbot
commit 55ab172a1f286742d918947ecb9b257ce31cc253
Author:     Andrew Cooper <[hidden email]>
AuthorDate: Fri May 5 17:38:19 2017 +0100
Commit:     Andrew Cooper <[hidden email]>
CommitDate: Tue May 9 19:00:04 2017 +0100

    x86/pv: Fix bugs with the handling of int80_bounce
   
    Testing has revealed two issues:
   
     1) Passing a NULL handle to set_trap_table() is intended to flush the entire
        table.  The 64bit guest case (and 32bit guest on 32bit Xen, when it
        existed) called init_int80_direct_trap() to reset int80_bounce, but c/s
        cda335c279 which introduced the 32bit guest on 64bit Xen support omitted
        this step.  Previously therefore, it was impossible for a 32bit guest to
        reset its registered int80_bounce details.
   
     2) init_int80_direct_trap() doesn't honour the guests request to have
        interrupts disabled on entry.  PVops Linux requests that interrupts are
        disabled, but Xen currently leaves them enabled when following the int80
        fastpath.
   
    Signed-off-by: Andrew Cooper <[hidden email]>
    Reviewed-by: Jan Beulich <[hidden email]>
    Release-acked-by: Julien Grall <[hidden email]>
---
 xen/arch/x86/x86_64/compat/traps.c | 1 +
 xen/arch/x86/x86_64/traps.c        | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/x86_64/compat/traps.c b/xen/arch/x86/x86_64/compat/traps.c
index 8e9a11c..1751ec6 100644
--- a/xen/arch/x86/x86_64/compat/traps.c
+++ b/xen/arch/x86/x86_64/compat/traps.c
@@ -339,6 +339,7 @@ int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps)
     if ( guest_handle_is_null(traps) )
     {
         memset(dst, 0, NR_VECTORS * sizeof(*dst));
+        init_int80_direct_trap(current);
         return 0;
     }
 
diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
index ad4d6c1..78f4105 100644
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -427,12 +427,13 @@ void init_int80_direct_trap(struct vcpu *v)
     struct trap_info *ti = &v->arch.pv_vcpu.trap_ctxt[0x80];
     struct trap_bounce *tb = &v->arch.pv_vcpu.int80_bounce;
 
-    tb->flags = TBF_EXCEPTION;
     tb->cs    = ti->cs;
     tb->eip   = ti->address;
 
     if ( null_trap_bounce(v, tb) )
         tb->flags = 0;
+    else
+        tb->flags = TBF_EXCEPTION | (TI_GET_IF(ti) ? TBF_INTERRUPT : 0);
 }
 
 static long register_guest_callback(struct callback_register *reg)
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog