[xen master] x86/traps: Drop redundant printk() in fatal_trap()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] x86/traps: Drop redundant printk() in fatal_trap()

patchbot
commit 30867b3c5a6dcf83426487fc431b395393db662c
Author:     Andrew Cooper <[hidden email]>
AuthorDate: Tue Nov 28 18:48:07 2017 +0000
Commit:     Andrew Cooper <[hidden email]>
CommitDate: Fri Dec 1 19:03:28 2017 +0000

    x86/traps: Drop redundant printk() in fatal_trap()
   
    show_page_walk() already prints the linear address of the walk, and
    show_execution_state() has printed a raw %cr2 value.  This avoids having
    two adjacent log lines with identical information.
   
      (XEN) Faulting linear address: 00000000025ff028
      (XEN) Pagetable walk from 00000000025ff028:
      ...
   
    Signed-off-by: Andrew Cooper <[hidden email]>
    Reviewed-by: Jan Beulich <[hidden email]>
---
 xen/arch/x86/traps.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 86506f3..c9a849c 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -650,11 +650,7 @@ void fatal_trap(const struct cpu_user_regs *regs, bool show_remote)
         show_execution_state(regs);
 
         if ( trapnr == TRAP_page_fault )
-        {
-            unsigned long cr2 = read_cr2();
-            printk("Faulting linear address: %p\n", _p(cr2));
-            show_page_walk(cr2);
-        }
+            show_page_walk(read_cr2());
 
         if ( show_remote )
         {
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog