[xen master] x86/vpmu: Remove unnecessary call to do_interrupt()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen master] x86/vpmu: Remove unnecessary call to do_interrupt()

patchbot
commit 5e2bfc23f7c9a60c01a02c619e1f3d7456ce0e93
Author:     Boris Ostrovsky <[hidden email]>
AuthorDate: Tue Oct 24 19:30:20 2017 -0400
Commit:     Andrew Cooper <[hidden email]>
CommitDate: Fri Oct 27 14:32:38 2017 +0100

    x86/vpmu: Remove unnecessary call to do_interrupt()
   
    This call was left during PVHv1 removal (commit 33e5c32559e1 ("x86:
    remove PVHv1 code")):
   
    -        if ( is_pvh_vcpu(sampling) &&
    -             !(vpmu_mode & XENPMU_MODE_ALL) &&
    +        if ( !(vpmu_mode & XENPMU_MODE_ALL) &&
                  !vpmu->arch_vpmu_ops->do_interrupt(regs) )
                 return;
   
    As result of this extra call VPMU no longer works for PV guests on Intel
    because we effectively lose value of MSR_CORE_PERF_GLOBAL_STATUS.
   
    Signed-off-by: Boris Ostrovsky <[hidden email]>
    Reviewed-by: Andrew Cooper <[hidden email]>
    Release-acked-by: Julien Grall <[hidden email]>
---
 xen/arch/x86/cpu/vpmu.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index fd2fcac..7baf461 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -227,10 +227,6 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
         if ( !vpmu->xenpmu_data )
             return;
 
-        if ( !(vpmu_mode & XENPMU_MODE_ALL) &&
-             !vpmu->arch_vpmu_ops->do_interrupt(regs) )
-            return;
-
         if ( vpmu_is_set(vpmu, VPMU_CACHED) )
             return;
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog