[xen stable-4.4] oxenstored: track commit history

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[xen stable-4.4] oxenstored: track commit history

commit b217630a0ed055abb058b4c4d067cbeed92bb4a2
Author:     Jonathan Davies <[hidden email]>
AuthorDate: Mon Mar 27 08:58:29 2017 +0000
Commit:     Ian Jackson <[hidden email]>
CommitDate: Wed Apr 5 15:26:38 2017 +0100

    oxenstored: track commit history
    Since the list of historic activity cannot grow without bound, it is safe to use
    this to track commits.
    Reported-by: Juergen Gross <[hidden email]>
    Signed-off-by: Jonathan Davies <[hidden email]>
    Reviewed-by: Thomas Sanders <[hidden email]>
 tools/ocaml/xenstored/process.ml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml
index f95992d..706b8a0 100644
--- a/tools/ocaml/xenstored/process.ml
+++ b/tools/ocaml/xenstored/process.ml
@@ -290,12 +290,7 @@ let write_response_log ~ty ~tid ~con ~response =
 let record_commit ~con ~tid ~before ~after =
  let inc r = r := Int64.add 1L !r in
  let finish_count = inc Transaction.counter; !Transaction.counter in
- (* This call would leak memory if historic activity is retained forever
-   so can only be uncommented if history is guaranteed not to grow
-   unboundedly.
  History.push {History.con=con; tid=tid; before=before; after=after; finish_count=finish_count}
- *)
- ()
 (* Replay a stored transaction against a fresh store, check the responses are
    all equivalent: if so, commit the transaction. Otherwise send the abort to
generated by git-patchbot for /home/xen/git/xen.git#stable-4.4

Xen-changelog mailing list
[hidden email]