[xen stable-4.8] rombios: prevent building with PIC/PIE

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen stable-4.8] rombios: prevent building with PIC/PIE

patchbot
commit ecb701f38c1035e0178b0a904f058a54862162c9
Author:     Olaf Hering <[hidden email]>
AuthorDate: Mon Aug 28 11:46:21 2017 +0200
Commit:     Jan Beulich <[hidden email]>
CommitDate: Mon Aug 28 11:46:21 2017 +0200

    rombios: prevent building with PIC/PIE
   
    If the default compiler silently defaults to to -fPIC/-fPIE building
    rombios fails:
   
     ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 32bitbios_all.o
     There are undefined symbols in the BIOS:
              U _GLOBAL_OFFSET_TABLE_
     make[10]: *** [Makefile:26: 32bitbios_all.o] Error 11
   
    Prevent the failure by enforcing non-PIC/PIE mode.
   
    Signed-off-by: Olaf Hering <[hidden email]>
    Acked-by: Andrew Cooper <[hidden email]>
    master commit: 672949d6c61d9cba01c5b414eed9d522082f04d3
    master date: 2017-06-26 14:32:46 +0100
---
 tools/firmware/rombios/32bit/Makefile         | 2 ++
 tools/firmware/rombios/32bit/tcgbios/Makefile | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/tools/firmware/rombios/32bit/Makefile b/tools/firmware/rombios/32bit/Makefile
index b0583c9..28c1544 100644
--- a/tools/firmware/rombios/32bit/Makefile
+++ b/tools/firmware/rombios/32bit/Makefile
@@ -4,6 +4,8 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
 TARGET = 32bitbios_flat.h
 
 CFLAGS += $(CFLAGS_xeninclude) -I.. -I../../../libacpi
+$(call cc-option-add,CFLAGS,CC,-fno-pic)
+$(call cc-option-add,CFLAGS,CC,-fno-PIE)
 
 SUBDIRS = tcgbios
 
diff --git a/tools/firmware/rombios/32bit/tcgbios/Makefile b/tools/firmware/rombios/32bit/tcgbios/Makefile
index f87d130..5cff4ef 100644
--- a/tools/firmware/rombios/32bit/tcgbios/Makefile
+++ b/tools/firmware/rombios/32bit/tcgbios/Makefile
@@ -4,6 +4,8 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
 TARGET  = tcgbiosext.o
 
 CFLAGS += $(CFLAGS_xeninclude) -I.. -I../.. -I../../../../libacpi
+$(call cc-option-add,CFLAGS,CC,-fno-pic)
+$(call cc-option-add,CFLAGS,CC,-fno-PIE)
 
 .PHONY: all
 all: $(TARGET)
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.8

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog