[xen stable-4.8] x86: check paging mode earlier in xenmem_add_to_physmap_one()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen stable-4.8] x86: check paging mode earlier in xenmem_add_to_physmap_one()

patchbot
commit e9558bee743bf72d0b1652ab58b7b9436736a14e
Author:     Jan Beulich <[hidden email]>
AuthorDate: Wed Dec 20 16:07:18 2017 +0100
Commit:     Jan Beulich <[hidden email]>
CommitDate: Wed Dec 20 16:07:18 2017 +0100

    x86: check paging mode earlier in xenmem_add_to_physmap_one()
   
    There's no point in deferring this until after some initial processing,
    and it's actively wrong for the XENMAPSPACE_gmfn_foreign handling to not
    have such a check at all.
   
    Signed-off-by: Jan Beulich <[hidden email]>
    Reviewed-by: George Dunlap <[hidden email]>
    Acked-by: Andrew Cooper <[hidden email]>
    master commit: f38f3dccf1e1a8aabcf57364326fc8f44cddc41a
    master date: 2017-11-28 13:14:43 +0100
---
 xen/arch/x86/mm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 43e0d39..be51d16 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5027,6 +5027,9 @@ int xenmem_add_to_physmap_one(
     int rc = 0;
     p2m_type_t p2mt;
 
+    if ( !paging_mode_translate(d) )
+        return -EACCES;
+
     switch ( space )
     {
         case XENMAPSPACE_shared_info:
@@ -5083,7 +5086,7 @@ int xenmem_add_to_physmap_one(
             break;
     }
 
-    if ( !paging_mode_translate(d) || (mfn == 0) )
+    if ( mfn == 0 )
     {
         if ( page )
             put_page(page);
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.8

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog