[xen stable-4.9] tools/libxc/xc_dom_arm: add missing variable initialization

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen stable-4.9] tools/libxc/xc_dom_arm: add missing variable initialization

patchbot
commit 2040ac14e4cfbae679751796266527d92d11ac78
Author:     Bernd Kuhls <[hidden email]>
AuthorDate: Sat Aug 19 16:21:42 2017 +0200
Commit:     Stefano Stabellini <[hidden email]>
CommitDate: Tue Oct 17 13:02:58 2017 -0700

    tools/libxc/xc_dom_arm: add missing variable initialization
   
    The variable domctl.u.address_size.size may remain uninitialized if
    guest_type is not one of xen-3.0-aarch64 or xen-3.0-armv7l. And the
    code precisely checks if this variable is still 0 to decide if the
    guest type is supported or not.
   
    This fixes the following build failure with gcc 7.x:
   
    xc_dom_arm.c:229:31: error: 'domctl.u.address_size.size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         if ( domctl.u.address_size.size == 0 )
   
    Patch originally taken from
    https://www.mail-archive.com/xen-devel@.../msg109313.html.
   
    Signed-off-by: Bernd Kuhls <[hidden email]>
    Signed-off-by: Thomas Petazzoni <[hidden email]>
    Acked-by: Wei Liu <[hidden email]>
    (cherry picked from commit 88bfbf90e35f1213f9967a97dee0b2039f9998a4)
---
 tools/libxc/xc_dom_arm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
index e7d4bd0..e669fb0 100644
--- a/tools/libxc/xc_dom_arm.c
+++ b/tools/libxc/xc_dom_arm.c
@@ -223,6 +223,8 @@ static int set_mode(xc_interface *xch, domid_t domid, char *guest_type)
 
     domctl.domain = domid;
     domctl.cmd    = XEN_DOMCTL_set_address_size;
+    domctl.u.address_size.size = 0;
+
     for ( i = 0; i < ARRAY_SIZE(types); i++ )
         if ( !strcmp(types[i].guest, guest_type) )
             domctl.u.address_size.size = types[i].size;
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.9

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog