[xen staging] gic-vgic: skip irqs locking in gic_restore_pending_irqs()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen staging] gic-vgic: skip irqs locking in gic_restore_pending_irqs()

patchbot
commit 31e67c156f3f539b6d64f3ace52439c07cb21341
Author:     Andrii Anisov <[hidden email]>
AuthorDate: Fri Dec 21 20:54:16 2018 +0200
Commit:     Julien Grall <[hidden email]>
CommitDate: Tue Mar 12 16:49:33 2019 +0000

    gic-vgic: skip irqs locking in gic_restore_pending_irqs()
   
    This function is called under IRQs disabled already, so drop additional
    flags save and restore.
   
    Signed-off-by: Andrii Anisov <[hidden email]>
    Reviewed-by: Julien Grall <[hidden email]>
---
 xen/arch/arm/gic-vgic.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
index a3bba854da..98c021f1a8 100644
--- a/xen/arch/arm/gic-vgic.c
+++ b/xen/arch/arm/gic-vgic.c
@@ -279,11 +279,12 @@ static void gic_restore_pending_irqs(struct vcpu *v)
     int lr = 0;
     struct pending_irq *p, *t, *p_r;
     struct list_head *inflight_r;
-    unsigned long flags;
     unsigned int nr_lrs = gic_get_nr_lrs();
     int lrs = nr_lrs;
 
-    spin_lock_irqsave(&v->arch.vgic.lock, flags);
+    ASSERT(!local_irq_is_enabled());
+
+    spin_lock(&v->arch.vgic.lock);
 
     if ( list_empty(&v->arch.vgic.lr_pending) )
         goto out;
@@ -327,7 +328,7 @@ found:
     }
 
 out:
-    spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
+    spin_unlock(&v->arch.vgic.lock);
 }
 
 void gic_clear_pending_irqs(struct vcpu *v)
--
generated by git-patchbot for /home/xen/git/xen.git#staging

_______________________________________________
Xen-changelog mailing list
[hidden email]
https://lists.xenproject.org/xen-changelog