[xen-unstable] xentrace: Don't append trace on existing file.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[xen-unstable] xentrace: Don't append trace on existing file.

Xen patchbot-unstable
# HG changeset patch
# User Keir Fraser <[hidden email]>
# Date 1196763452 0
# Node ID 190c2592247d3258d6b2c60939d27928c70ac5ca
# Parent  6e7cf648f7f3486e532be332bb4d832bbfe9784a
xentrace: Don't append trace on existing file.

When you run "xentrace -e <mask> trace.output" the first time, all is
fine. When you run it a second time, then the data is appended which
makes you reading old data with xentrace_format and you interprete it
as new data. This usually happens when you automated tracing guests
with xentrace and xentrace_format with a script.

Therefore, attached patch makes xentrace to truncate the file to zero
bytes before writing any data.

Signed-off-by: Christoph Egger <[hidden email]>
---
 tools/xentrace/xentrace.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff -r 6e7cf648f7f3 -r 190c2592247d tools/xentrace/xentrace.c
--- a/tools/xentrace/xentrace.c Tue Dec 04 10:13:04 2007 +0000
+++ b/tools/xentrace/xentrace.c Tue Dec 04 10:17:32 2007 +0000
@@ -572,24 +572,24 @@ int main(int argc, char **argv)
 
     parse_args(argc, argv);
     
-    if (opts.evt_mask != 0) {
+    if ( opts.evt_mask != 0 )
         set_mask(opts.evt_mask, 0);
-    }
-
-    if (opts.cpu_mask != 0) {
+
+    if ( opts.cpu_mask != 0 )
         set_mask(opts.cpu_mask, 1);
-    }
 
     if ( opts.outfile )
-        outfd = open(opts.outfile, O_WRONLY | O_CREAT | O_LARGEFILE, 0644);
-
-    if(outfd < 0)
+        outfd = open(opts.outfile,
+                     O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE,
+                     0644);
+
+    if ( outfd < 0 )
     {
         perror("Could not open output file");
         exit(EXIT_FAILURE);
     }        
 
-    if(isatty(outfd))
+    if ( isatty(outfd) )
     {
         fprintf(stderr, "Cannot output to a TTY, specify a log file.\n");
         exit(EXIT_FAILURE);

_______________________________________________
Xen-changelog mailing list
[hidden email]
http://lists.xensource.com/xen-changelog